Changed Portuguese (Portugal) .po to pt_PT #2049
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Portuguese (Portugal) translations should be pt_PT, just like the Portuguese (Brazil) translation pt_BR
The Portuguese (Portugal) .po should be pt_PT.po like the Portuguese (Brazil) translation pt_BR.po
Owner
|
Thanks for the PR! I get what you mean about keeping things consistent with pt_BR, but in this case pt.po is actually the correct name. In gettext/Meson/Weblate setups, pt already stands for Portuguese from Portugal. Changing it to pt_PT.po would break language detection and also cause issues in Weblate, since it expects the file to stay as pt.po. So for now it’s better to keep the current naming to avoid problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency and for Planify to actually use the Portuguese (Portugal) language in a system using that language, we should rename the pt.po file to pt_PT.po, just like we do for the Portuguese (Brazil) translation pt_BR.po.
This change should also be made in weblate because, I think, it uses the name pt.po.
Thank you